NMC-life model issues in extreme cold

[brtietz]

Describe the bug

To test how the battery model performs in extreme cold, I put in weather file temperature data for Fairbanks, AK into the "enter the time series temperature" slot. This raised a few issues:

1. Since the NMC-life model handles temperature as well, 5+ battery replacements are triggered each year
2. The battery capacity percent for temperature output is stuck at 100%

To Reproduce

Steps to reproduce the behavior:

1. Download the zip and add the weather file to your library
2. Run extreme_cold_nmc_life case extreme_cold_tests.zip

Expected behavior

For (1) - the battery degradation code might need to look at a different value

For (2) - we should either tie the temperature % code to a different value or remove it from the outputs. Additionally if the inputs on in the chart the battery thermal page are unused for a given life model, they should be disabled in the UI.

Screenshots

Operating System and Version

• Version 2022.11.21. I expect this is a problem in 2021.12.02 as well

[brtietz]

Adding to the patch to solve (2). (1) might get split off into it's own issue.

[dguittet]

The state->qmax_thermal output is currently not tied to a value in the NMC/Gr model and there isn't a clear answer for what value it could even be tied to. The calendar_cycle model clearly differentiates between calendar, cycling and thermal whereas the NMC/Gr model differentiates between QLi and QNeg (QPos was not modeled). The thermal part of the model is embedded in both part of QLi and QNeg.

I think it would make more sense for the UI to show state->nmc_li_neg->q_relative_li and state->nmc_li_neg->q_relative_neg instead of qmax_thermal for the NMC/Gr model.

[dguittet]

@cpaulgilman @mjprilliman Is it possible to show only a subset of outputs in the Results depending on some variable?