search

NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
345 stars 142 forks source link

SAM_AdjustmentFactors missing variables required for PySAM #1661

Closed dguittet closed 1 month ago

dguittet commented 11 months ago

Describe the bug Currently the AdjustmentFactors module is manually maintained, not regenerated by export_config. This was done because adjust used to have names with ":" that conflicted with the libSAMapi interface. Adjustment factors have since been modified and new variables have been added, but SAM_AdjustmentFactors and the PySAM adjustment factors haven't been modified to follow those changes.

The automatic generation is not possible with the code as-is for the following reason. In order to use hourly, period, or timeindex adjustment factors, the enabling variable is required, such as "adjust_en_hourly". These variables are however commented out: https://github.com/NREL/ssc/blob/75b4b1778d88234149bbb693d72914c2293ee721/ssc/common.cpp#L524

So they wouldn't make it to the PySAM interface.

Expected behavior Adjustment factors need to have all the variables required for its use.

Propose manually modifying the SAM_AdjustmentFactors and PySAM files for now.

brtietz commented 1 month ago

@dguittet should this be closed based on #1826 ?