search

NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
337 stars 139 forks source link

REopt API returns zero battery size in unexpected situations #1723

Closed brtietz closed 4 months ago

brtietz commented 7 months ago 
          >... I'm having an issue where the REopt call always returns a zero battery size from this branch, even in cases where the battery has obvious value (PVWatts-Battery commercial), and cases where it returns a battery size in the released version. Did you see this as you were developing the branch? Or is this more likely to be a bug on their end?

I also saw this. Sometimes rerunning REopt a few times results in a non-zero battery, so I'm not sure if it's SAM sending different data to the API or something on the REopt side. Also, the default case in this branch/Patch has different battery parameters than the default:

image

If you agree, I'd like to close this so we can fix the issue of REopt API calls causing SAM to crash, and investigate this as a separate issue for Patch 2.

Originally posted by @cpaulgilman in https://github.com/NREL/SAM/issues/1714#issuecomment-1970196094

brtietz commented 4 months ago

Duplicate with https://github.com/NREL/SAM/issues/1742