NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
318 stars 136 forks source link

UI Message for Battery Grid Charging with PBI #1792

Closed cpaulgilman closed 2 weeks ago

cpaulgilman commented 3 weeks ago

Modify existing UI callback function that displays message when grid charging is enabled with PTC to also display message with PBI.

Also trigger message on_change so message appears when you switch to Battery Dispatch pages.

Pull Request Template

Description

Fixes #1759

Type of change

Please delete options that are not relevant.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

cpaulgilman commented 3 weeks ago

There's a minor consistency issue in the defaults: the default PBI term for front of meter is 10 years, whereas for BTM it's 0 years. That should be a separate issue if we choose to address it and can probably wait until the release.

I think the default term should be zero if the default amount is zero to force the user to set both the PBI amount and term -- otherwise they may just set the PBI amount and not notice the term.