search

NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
337 stars 140 forks source link

Consistently set the default PBI term to zero #1794

Closed brtietz closed 1 week ago

brtietz commented 3 months ago 
          > There's a minor consistency issue in the defaults: the default PBI term for front of meter is 10 years, whereas for BTM it's 0 years. That should be a separate issue if we choose to address it and can probably wait until the release.

I think the default term should be zero if the default amount is zero to force the user to set both the PBI amount and term -- otherwise they may just set the PBI amount and not notice the term.

Originally posted by @cpaulgilman in https://github.com/NREL/SAM/issues/1792#issuecomment-2168252099

brtietz commented 1 week ago

Consolidated in https://github.com/NREL/SAM/issues/1855