Improve Documentation of IEC 61858 temperature, optical, and spectral models - Githubissues

NREL / SAM

System Advisor Model (SAM)

BSD 3-Clause "New" or "Revised" License

337 stars 140 forks source link

Improve Documentation of IEC 61858 temperature, optical, and spectral models #1795

Closed cpaulgilman closed 3 months ago

cpaulgilman commented 3 months ago

Help Revisions:

Revise IEC 61853 topic to explain temperature model

Revise IEC 61853 topic to explain optical and spectral models

Add note for CEC model to explain air mass model.

UI Updates

Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file.

Improve labeling of inputs for IEC 61853 module model

Fixes #1781

Goes with https://github.com/NREL/ssc/pull/1175

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings