search

NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
345 stars 142 forks source link

Ensure all techs with a time series have availablity losses #985

Closed brtietz closed 1 month ago

brtietz commented 2 years ago

We noticed on 3/15/22 that the wind losses page is missing the hourly availability input. Check the other techs to see if it is missing elsewhere, and add it to the appropriate categories.

janinefreeman commented 1 year ago

This input seems to have been added back to wind.

However, the input is missing from: standalone battery; marine wave, wave+battery, and tidal (have a flat rate availability input instead). Note that there is a "marine availability" input page but it does not appear to be used in startup.lk.

Fuel cell and battery both don't have their own availability loss, which is true of all hybrid configs containing these two.

For further discussion at the next SAM meeting.

janinefreeman commented 1 year ago

Discussed creating a specific UI page for the availability losses, and allowing them to be applied to each component of a system (i.e. PV would have a separate availability loss than batteries).

brtietz commented 1 year ago

A note on the availability losses in batteries: Essentially, the availability loss puts a giant resistor between the battery and the load, and burns a percentage of the energy in each timestep. In reality, an availability loss for the battery would knock out part of the battery’s power or energy capacity, but if the battery discharged 3 kW for an hour, 3 kWh from the storage would be depleted. Right now a 10% availability loss would discharge an additional 0.3 kWh.

Clean this up as a part of this issue.

janinefreeman commented 1 month ago

Related #1247

brtietz commented 1 month ago

Split this into one issue per technology.

Add an availability loss widget to the battery. This should limit both power and capacity of the battery.

AC connected batteries should not be affected by PV losses. In the DC connected case, the battery availability loss affects the DC output power, and the AC loss affects discharging or charging from the grid as it does now (test this to make sure it makes sense).

mjprilliman commented 1 month ago

https://github.com/NREL/SAM/issues/1247 tracking for wave, tidal, wave battery.

brtietz commented 1 month ago

https://github.com/NREL/SAM/issues/1868 for wind https://github.com/NREL/SAM/issues/1869 for batteries (may include adjustments to PVsamv1) https://github.com/NREL/SAM/issues/1870 for fuel cells