NREL / SOEP-QSS-Test

0 stars 1 forks source link

ASHRAE2006 and Guideline36 fails to simulate with directional derivatives #21

Closed chria closed 2 years ago

chria commented 2 years ago

PyFMI simulation of ASHRAE2006 & Guideline36 fails when directional derivatives are turned on:

ASHRAE2006 Warning: Possible chattering detected at t = 1.308000e+04 in state event(s): [57 59 61 63 65] Simulation failed: 'The right-hand side function had repeated recoverable errors. At time 39240.000000.

Guideline36 "Simulation failed: 'The right-hand side function had repeated recoverable errors. At time 39120.000000.'"

modelonrobinandersson commented 2 years ago

This seems to caused by two issues that are resolved in the next version of OCT:

  1. zeroDerivatives were not picked up correctly, which was used by the function Buildings.Fluid.BaseClasses.FlowModels.basicFlowFunction_dp, which in turn propagated further down.
  2. We have now improved how the directional derivative is calculated for expressions such as x^y when x approaches 0 and y>1.
DeadParrot commented 2 years ago

Both models' PyFMI (CVode) runs complete with FMUs built with directional derivative support using OCT dev build OCT-dev-cw-5212-18478f3488ff1272c52222a29d72215983eadeec.

Both models still give "Possible chattering" warnings but if that proves to indicate model problems that affect QSS a separate Issue will be opened.

DeadParrot commented 2 years ago

Thanks, Robin. I will see how these 2 models run now.

I need to understand more about how derivative annotations affect the generated FMU and QSS. Specifically, can someone describe:

If we eventually need to support this I guess I need to know if we need to do anything on the QSS side for models like these that use derivative annotations.

Regards, Stuart -- Stuart Mentzer Objexx Engineering objexx.com +1 781 455 1150

On Tue, Aug 16, 2022 at 12:32 PM Robin Andersson @.***> wrote:

This seems to caused by two issues that are resolved in the next version of OCT:

  1. zeroDerivatives were not picked up correctly, which was used by the function Buildings.Fluid.BaseClasses.FlowModels.basicFlowFunction_dp, which in turn propagated further down.
  2. We have now improved how the directional derivative is calculated for expressions such as x^y when x approaches 0 and y>1.

— Reply to this email directly, view it on GitHub https://github.com/NREL/SOEP-QSS-Test/issues/21#issuecomment-1216875515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSR3ICY74L6ZODZRDVBA3VZO7A5ANCNFSM5XNTDWAA . You are receiving this because you are subscribed to this thread.Message ID: @.***>