Open DeadParrot opened 3 years ago
@DeadParrot : Please let me know if flow1 * flow2 >= 0
should be changed to sign(flow1) == sign(flow2)
. This is used for example at
https://github.com/lbl-srg/modelica-buildings/blob/9e561662dbcb4fdc65014c7ae57dacb55f9b49c3/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo#L158
@mwetter: The use of flow1 * flow2
degraded numerical differentiation somewhat so it is probably best to use the sign
form, but this usage hasn't yet been shown to be a significant cause of QSS simulation problems for those models. Once QSS simulation of those models is working I can retry with a modified Buildings library that uses the sign
version and see if this is beneficial.
Current issues related to the Buildings Library are:
bin
have a mechanism to specify a Buildings Library revision to use but this is non-ideal due to the overhead of cloning the Buildings Library for each such FMU build and because the model can then not benefit from updates. The solutions probably include:flow1 * flow2 >= 0
as a shorthand forsign(flow1) == sign(flow2)