NREL / SOEP-QSS-Test

0 stars 1 forks source link

Buildings Library #6

Open DeadParrot opened 3 years ago

DeadParrot commented 3 years ago

Current issues related to the Buildings Library are:

mwetter commented 3 years ago

@DeadParrot : Please let me know if flow1 * flow2 >= 0 should be changed to sign(flow1) == sign(flow2). This is used for example at https://github.com/lbl-srg/modelica-buildings/blob/9e561662dbcb4fdc65014c7ae57dacb55f9b49c3/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo#L158

DeadParrot commented 3 years ago

@mwetter: The use of flow1 * flow2 degraded numerical differentiation somewhat so it is probably best to use the sign form, but this usage hasn't yet been shown to be a significant cause of QSS simulation problems for those models. Once QSS simulation of those models is working I can retry with a modified Buildings library that uses the sign version and see if this is beneficial.