NREL / SOEP-QSS

BSD 3-Clause "New" or "Revised" License
11 stars 4 forks source link

Allow value reference duplicates for fixed and non-state/derivative variables #3

Closed DeadParrot closed 3 years ago

DeadParrot commented 3 years ago

Recently added code detects value reference duplication in any FMU variables but such duplicates are allowed/expected for fixed parameters with the same value and for varying value variables that are aliases so the check should be adjusted to only detect/reject duplicates between state or derivative variables or between fixed parameters with different values.

DeadParrot commented 3 years ago

Addressed by 3f42209d01fdc8be5ad6344216d230da16a291bd

Only checking for state and derivative reference value duplicates due to complexity and implementation dependence of when duplicates may appear elsewhere.