- Fix a typo? on src/finiteVolume/Make/files: timeVaryingMappedFluctu…

pablo-benito commented 7 years ago

Fix typo on src/finiteVolume/Make/files: timeVaryingMappedFluctuatingFixedValue.C does not exist, but timeVaryingMappedFluctuatingFixedValueFvPatchFields.C does.
Add library libuserfiniteVolume as a dependency to windPlantSolver.ALMAdvancedFASTv8/2.3-and-higher/options
Add extra paths to HDF5 includes

mchurchf commented 7 years ago

Pablo,

Thanks for the fixes that you have included here. I agree that the timeVaryingMappedFluctuatingFixedValue part is a typo, so that definitely needs to be fixed. Before I merge this, though, can you tell me what was happening when you did not have the HDF5 includes in the options files? I didn't face any problem when I do not have the include in there, but maybe it is system dependent.

pablo-benito commented 7 years ago

Yes, I had to include it because, on those options files you're including the Fastv8 headers, and in particular the code is including the fast header $(FAST_DIR)/include/SC.h. Inside this file, (at least in my Fastv8 version from https://github.com/gantech/fastv8DriverProgram) there is an #include "hdf5.h". In my system, the file hdf5.h is not in the 'usual' paths.. (not in "/usr/include/", "/usr/local/include" and so on..) so the compilation fails with an error ( "cannot find hdf5.h" )

Maybe you have those headers inside /usr/include and the compilation works for you ..

NREL / SOWFA

- Fix a typo? on src/finiteVolume/Make/files: timeVaryingMappedFluctu… #13