NREL / SolarPILOT

SolarPILOT power tower layout and optimization tool
https://www.nrel.gov/csp/solarpilot.html
Other
47 stars 17 forks source link

Cosine overwitten by intercept in _detail_results #26

Closed davidagross closed 6 years ago

davidagross commented 6 years ago

Just found this in the text while browsing the source for intercept calculation methods.

https://github.com/NREL/SolarPILOT/blob/develop/app/scripting.cpp#L709

            p.hash_item( "cosine", H->getEfficiencyIntercept() );
            p.hash_item( "intercept", H->getEfficiencyIntercept() );
mjwagner2 commented 6 years ago

Thanks @davidagross, good catch. I'll correct this in the next patch release. The revised code is included in a commit here.