Jira-REVIT-207412+207446

anchapin commented 9 months ago

This PR fixes the issue in this Jira ticket. Refer to the spreadsheet "Update Index for E+ Report.xlsx" in the Teams folder for more information.

Specifically, the two main sheets to refer to are "Inputs for code" and "SQL Query". I was able to figure out the SQL query being used to generate the column name order and entered it in cell D1 of the "SQL Query" sheet. To get the resulting ColumnName list, I ran a sample Energyplus model on my machine. Then utilized the SQL file, I copied it into the Teams folder, and a database viewer program to get the list using the query.

The "Inputs for code" sheet converts the list into the correct format to copy into the corresponding ruby files in the repo.

Note that I don't have time to test this out in REVIT yet. Hopefully, it can be confirmed quickly that this change fixes the issue.

Additionally, there is at least one other Jira issue that may also be served by the fix or something similar.

eringold commented 9 months ago

Verified this fixes the Jira ticket. With these changes, 'Time of Peak' on Design Psychrometrics page is correct:

eringold commented 9 months ago

Also fixes https://jira.autodesk.com/browse/REVIT-207412

MatthewSteen commented 9 months ago

@eringold no need to (re)review, just organizing. Could you post some images of the the 207412 fix?

eringold commented 9 months ago

@MatthewSteen From REVIT-207412: v2023 (original, working): v2024 (broken):

this PR:

NREL / SystemsAnalysisReports

Jira-REVIT-207412+207446 #87