search

NREL / SystemsAnalysisReports

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Fix Revit 221153 #98

Open eringold opened 2 months ago

eringold commented 2 months ago

Fixes https://github.com/NREL/SystemsAnalysisReports/issues/96

When multizone coils are hard-sized in the simulation, the Coil Sizing Details report writes 'default' (uncalculated, -999) values to the ideal loads temperature/humidity ratio state points, which caused the psychrometric routines used in populating the Design Psychrometrics report to fail. This change catches the default values and returns nil instead, and edits the design psychrometrics report generator to handle nil/null values. When all null values are detected, the psychrometrics summary table is replaced with a message that valid state points were not found due to hardsizing: image The psychrometric chart is and Summary table are still shown, but with the missing data. Also, the printed PDF is generated with the psychrometric table, with blank values.

Future refinements will be needed to handle the bad data shown in the Summary Table, if requested.

MatthewSteen commented 2 weeks ago

Note to check 11 Jay St..xml report, which doesn't work.