NREL / ThermalNetwork

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

System Parameter File needs to be updated with results after running Thermal Network #5

Closed tanushree04 closed 11 months ago

tanushree04 commented 1 year ago

The thermalnetwork cli call used to size GHE, takes the system parameter file path as an input. This file needs to be updated in the same path with the following fields :

vtnate commented 12 months ago

@tanushree04 Can you provide some more detail? For instance, if we want data from the SimulationSummary.json, which fields are important to return to the sys-param file?

Are we updating all data fields inside ghe_specific_params? https://github.com/NREL/ThermalNetwork/blob/main/demos/sdk_output_skeleton_2_ghe_sequential/run/baseline_scenario/ghe_dir/sys_params.json#L133

Where do I find the data to update the ghe_geometric_params https://github.com/NREL/ThermalNetwork/blob/main/demos/sdk_output_skeleton_2_ghe_sequential/run/baseline_scenario/ghe_dir/sys_params.json#L136?

I wish I could link to an example of SimulationSummary.json, but it's created by GHEDesigner. To create one, call the CLI using the demos files ThermalNetwork to generate sample output.

tanushree04 commented 12 months ago

@vtnate https://github.com/NREL/ThermalNetwork/blob/main/demos/sdk_output_skeleton_2_ghe_sequential/run/baseline_scenario/ghe_dir/sys_params.json#L156-L157

These 2 fields need to be updated