NREL / ThermalNetwork

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Moar testing #8

Closed vtnate closed 11 months ago

vtnate commented 12 months ago

DISCUSSION! Running our two_ghe test takes too much memory/cpu for the (free) GHA runner, which cancels the test. Googling around found https://github.com/actions/runner-images/issues/6680 which explains it. This implies our options are:

  1. Splash cash for bigger runners
  2. Honey I shrunk the test
  3. Not run the two_ghe test (at least comment it so it doesn't run automatically on CI)

I think option 3 is the best combination of low cost but still allows us to run the test locally. @mitchute wat do?

Some of the tests weren't running because the paths were outdated. This PR:

mitchute commented 12 months ago

@vtnate my first question is why the two ghe test is consuming so much memory/resources? I'm not necessarily expecting you to have an immediate answer, but GHEDesigner should be pretty capable of handling GHE with several thousand boreholes. If we are attempting GHE that are HUGE, then I say, yes, let's shrink it. If not, there must be some other issue.

vtnate commented 12 months ago

Thanks @mitchute, that's good context. I'll dig into the profiling to see where this is blowing up. GHA doesn't tell me if the problem is memory or cpu, just that it's one of those. Nor does GHA tell me what the limits are, only that we're over them. 🙄