search

NREL / bifacial_radiance

Toolkit for working with RADIANCE for the ray-trace modeling of Bifacial Photovoltaics
https://bifacial-radiance.readthedocs.io
BSD 3-Clause "New" or "Revised" License
84 stars 46 forks source link

Probably bug-causing double line in the pip default materials/ground.rad file #443

Closed Leo-Raumann closed 1 year ago

Leo-Raumann commented 1 year ago

Hi,

I just did a fresh test installation via pip install bifacial_radiance on a new user profile and got "fatal - (materials\ground.rad): undefined modifier "5"\r\n'". I think to remember that I had this already several times now after setting up new profiles in the past and had to fix it always by deleting once one of the lines of modifiers for this material here:

...
#Concrete (from SMARTS) albedo 0.28
void plastic concrete
0
0
5 .364 .257 .2235 0 0
5 .863 .791 .745 0 0

#CU Boulder Beige roof (clean) albedo 0.43
...

Could you look into that?

Best regards Leo

shirubana commented 1 year ago

Hi Leo,

I am checking the file in the main and the development branch, and both don't have that line. I wonder if it somehow got corrupted in one of your installs, and on re-installs it is not really rewriting the wrong file?

Leo-Raumann commented 1 year ago

Hi Silvana,

I checked now what is happening in the background and understood that bifacial_radiance copies the materials/ground.rad from the \AppData\Local\Programs\Python\Python310\lib\site-packages\bifacial_radiance\data folder if the materials folder does not exists within the working directory.

I am sorry to have wasted your time here with this issue. I think I somehow messed up my ground.rad editing method. Once I deleted the double line, all is working fine but when copying the file for the first time from the ...site-packages\bifacial_radiance... (which is indeed not corrupted, as I just saw), I have the bug, which is caused by my code. That's also the reason that it happened on a fresh user profile as well... I will fix it now.

Thanks and best regards Leo