search

NREL / bifacial_radiance

Toolkit for working with RADIANCE for the ray-trace modeling of Bifacial Photovoltaics
https://bifacial-radiance.readthedocs.io
BSD 3-Clause "New" or "Revised" License
91 stars 48 forks source link

Refactor NSRDBWeatherData #496

Closed cdeline closed 6 months ago

cdeline commented 1 year ago

On the dev branch, refactor NSRDBWeatherData function to be a more general readWeatherData. This splits the existing readWeatherFile function into two parts - the first half for reading different weather files (TMY3, SAM, EPW, solarGIS) and putting it into a consistent format metadata dictionary and metdata DataFrame. Then the new readWeatherData function takes those inputs and does the parsing work. Now, NSRDB data can just be injected into the readWeatherData function without requiring any special function.

shirubana commented 8 months ago

did this got finished to merge ?

cdeline commented 6 months ago

Yes, this is functional and has pytests. We might want to consider demonstrating the functionality in a notebook or two, with the new function name readWeatherData