search

NREL / bifacial_radiance

Toolkit for working with RADIANCE for the ray-trace modeling of Bifacial Photovoltaics
https://bifacial-radiance.readthedocs.io
BSD 3-Clause "New" or "Revised" License
83 stars 46 forks source link

pass a copy of sceneDict to _makeSceneNxR. fixes #502. #503

Open cdeline opened 3 months ago

cdeline commented 3 months ago

instead of copying some of the keys of sceneDict into a sceneDict2 and passing that to _makeSceneNxR, this updates the appropriate keys, and makes sure that _makeSceneNxR is working from a copy.deepcopy of sceneDict. Because it's a mutable type, this dict was being updated within the makeScene1axis loop. Using a copy here solves that problem.

cdeline commented 3 months ago

@shirubana - I think this quick bug fix is ready to go. Tests are passing aside for the minor delta in coveralls coverage.

shirubana commented 3 months ago

@cdeline I see you removed removed hub_height from the dictionary. Is it still being saved somewhere? 

    # we no longer need sceneDict['hub_height'] - it'll be replaced by 'clearance_height' below
    sceneDict.pop('hub_height',None)

Other htan that I'm okay to merge