NREL / bifacialvf

Bifacial PV View Factor model for system performance calculation
https://bifacialvf.readthedocs.io
Other
29 stars 18 forks source link

Correct sun position calculation leap year #10

Closed nickdiorio closed 5 years ago

nickdiorio commented 6 years ago

Within the solarPos calculation, the "leap" variable is being treated as a float, resulting in minor errors in solar position. According to the reference paper, this parameter should only be taken as the integer portion: link

Please see section 2.1.