search

NREL / bifacialvf

Bifacial PV View Factor model for system performance calculation
https://bifacialvf.readthedocs.io
Other
29 stars 18 forks source link

TEST: testing #14

Closed mikofski closed 5 years ago

mikofski commented 5 years ago

Note: this PR builds upon #13

mikofski commented 5 years ago

Hi @shirubana and @cdeline , I think this is ready. This PR just focuses on bifacialvf/vf.py and adds 10 tests for the sky configuration factors. I also simplified some of the code, in particular, I replaced ATAN quadrant checking if-statements with the 4-quadrant ATAN2 – since the tests are all based on the original code in MASTER, then the tests prove/document that these code changes do not change the output. I also added a few comments and a sketch to make the terminology easier to understand.

mikofski commented 5 years ago

Yes on Travis, it also will build wheels and deploy them to PyPI (and GitHub releases) automatically for you, when you push a Git tag up to GitHub. All you need is a .travis.yml like RdTools, add bifacialvf to NREL's TravisCI account, encrypt your secrets, and hopefully it just works.