search

NREL / bifacialvf

Bifacial PV View Factor model for system performance calculation
https://bifacialvf.readthedocs.io
Other
29 stars 18 forks source link

BUG: fix imports so they work #16

Closed mikofski closed 5 years ago

mikofski commented 5 years ago

closes #15

cdeline commented 5 years ago

@mikofski This pull request appears to do the same thing as #13 which was merged into development yesterday. Can you confirm that this pull request is redundant?

mikofski commented 5 years ago

Not redundant exactly, but a prerequisite. #13 cleans up the doc strings, but for sphinx to work the imports needed to be fixed first. But yes in practice #13 already contains this PR, by necessity. Sorry.

mikofski commented 5 years ago

Other projects are very particular about mixing PRs, that's why I separated them, it makes the history easier to understand

mikofski commented 5 years ago

Closing since these changes were already merged in #13 (f8664273cdbb2c80a4e751731ebd04abda2dd9d0)