NREL / bifacialvf

Bifacial PV View Factor model for system performance calculation
https://bifacialvf.readthedocs.io
Other
29 stars 18 forks source link

Py3.8 requirements.txt error #34

Closed cdeline closed 4 years ago

cdeline commented 4 years ago

Requirements.txt probably needs to be updated to be py3.8 compatible. Getting an environment error on pip install -r requirements.txt:

ERROR: Command errored out with exit status 1: command: 'C:\Users\cdeline\anaconda3\envs\py38\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\Users\cdeline\AppData\Local\Temp\1\pip-install-1k8_x_xw\matplotlib\setup.py'"'"'; file='"'"'C:\Users\cdeline\AppData\Local\Temp\1\pip-install-1k8_x_xw\matplotlib\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\cdeline\AppData\Local\Temp\1\pip-install-1k8_x_xw\matplotlib\pip-egg-info' cwd: C:\Users\cdeline\AppData\Local\Temp\1\pip-install-1k8_x_xw\matplotlib\ Complete output (61 lines):

Edit setup.cfg to change the build options

BUILDING MATPLOTLIB
            matplotlib: yes [2.2.2]
                python: yes [3.8.2 (default, Apr 14 2020, 19:01:40) [MSC
                        v.1916 64 bit (AMD64)]]
              platform: yes [win32]

REQUIRED DEPENDENCIES AND EXTENSIONS
                 numpy: yes [version 1.18.3]
      install_requires: yes [handled by setuptools]
                libagg: yes [pkg-config information for 'libagg' could not
                        be found. Using local copy.]
              freetype: no  [The C/C++ header for freetype
                        (freetype2\ft2build.h) could not be found.  You may
                        need to install the development package.]
                   png: no  [The C/C++ header for png (png.h) could not be
                        found.  You may need to install the development
                        package.]
                 qhull: yes [pkg-config information for 'libqhull' could not
                        be found. Using local copy.]

OPTIONAL SUBPACKAGES
           sample_data: yes [installing]
              toolkits: yes [installing]
                 tests: no  [skipping due to configuration]
        toolkits_tests: no  [skipping due to configuration]

OPTIONAL BACKEND EXTENSIONS
                macosx: no  [Mac OS-X only]
                qt5agg: no  [PySide2 not found; PyQt5 not found]
                qt4agg: no  [PySide not found; PyQt4 not found]
               gtk3agg: no  [Requires pygobject to be installed.]
             gtk3cairo: no  [Requires cairocffi or pycairo to be installed.]
                gtkagg: no  [Requires pygtk]
                 tkagg: yes [installing; run-time loading from Python Tcl /
                        Tk]
                 wxagg: no  [requires wxPython]
                   gtk: no  [Requires pygtk]
                   agg: yes [installing]
                 cairo: no  [cairocffi or pycairo not found]
             windowing: yes [installing]

OPTIONAL LATEX DEPENDENCIES
                dvipng: no
           ghostscript: no
                 latex: no
               pdftops: no

OPTIONAL PACKAGE DATA
                  dlls: no  [skipping due to configuration]

============================================================================
                        * The following required packages can not be built:
                        * freetype, png
                        * Please check http://gnuwin32.sourceforge.net/packa
                        * ges/freetype.htm for instructions to install
                        * freetype
                        * Please check http://gnuwin32.sourceforge.net/packa
                        * ges/libpng.htm for instructions to install png
----------------------------------------

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

cdeline commented 4 years ago

Potential issue here - requirements.txt dependencies will break if pandas and numpy versions are explicitly stated, because there is no single version that works with both py27 and py38. Either 1: drop py2.7 support, 2: drop numpy and pandas from requirements.txt, or 3. drop py38 support at the moment. I'm going with 1.

cdeline commented 4 years ago

Fixed in development.