search

NREL / bioluc

3 stars 3 forks source link

Review & correction of abbreviation list #14

Closed lvimmers closed 11 years ago

lvimmers commented 11 years ago

The second tab of this file GitHub\bioluc\testing\Variables with types.xls contains an abbreviations list. It needs review:

  1. to check and complete the definitions field
  2. to agree or disagree with the abbreviations that I propose NOT to use

Please DON'T review all of the proposed variable names on the first tab yet, as Brian is developing automated correction for capitalization and I'd like that to be complete so that you can review all proposed variable names at once

StevenPeterson commented 11 years ago

made a few changes to the definition file (CP = commodity product not crop product) I am OK with the abbreviations. although some of the long words may mean we'll need to move names around on the diagram when we are all done changing names. Putting this back in Laura's lap.

lvimmers commented 11 years ago

Steve, do you want me to propose names that work better? If so, can you give me a character limit or tell me which ones are problematic? If not, then I don't know how I can help further. I don't think I have to approve final names.

StevenPeterson commented 11 years ago

I think we’ll be OK in changing the names as you have suggested. This should not be a huge issue. I’ll need to go through and potentially move names around on the diagram anyway, just before we ship.

--sp

Steve Peterson

Mobile (primary)....................603.359.7188

Office Phone/Fax...................603.298.7573

From: lvimmers [mailto:notifications@github.com] Sent: Friday, September 20, 2013 1:51 PM To: NREL/bioluc Cc: StevenPeterson Subject: Re: [bioluc] Review & correction of abbreviation list (#14)

Steve, do you want me to propose names that work better? If so, can you give me a character limit or tell me which ones are problematic? If not, then I don't know how I can help further. I don't think I have to approve final names.

— Reply to this email directly or view it on GitHubhttps://github.com/NREL/bioluc/issues/14#issuecomment-24828332 .

lvimmers commented 11 years ago

OK, then I am reassigning this issue to you to close when you are done.

StevenPeterson commented 11 years ago

Brian, I am passing this as well as the issue around vbl documentation back to you (#13, I believe). I have added three tabs to Laura's spreadsheet.
SP regional Vbls contains a list of regional variables, consistent with BRAZIL from tab 1. It provides documentation for each. SP Global VBLS contains a list of vbls in the current Global module, along with documentation. SP Changes to vbls contains a list of deletions and additions to vbls in BRAZIL and Global in the first tab.. I have not deleted/added vbls to other regions in the list in the first tab.

Model changes are in SVN build 3906. I will sync the spreadsheet in a few minutes.

Take a look, and we should talk.