search

NREL / buildstockbatch

Other
21 stars 14 forks source link

Warn if duplicate upgrade names #190

Open asparke2 opened 3 years ago

asparke2 commented 3 years ago

While doing QAQC on a recent ComStock run, I realized that there were multiple upgrades in the yml file that had the same name (see below). Although I was able to differentiate them programmatically using the upgrade_id, making user-facing results plots required an extra mapping layer. At a minimum I think it would be helpful to check and warn for this. If there's no use case we can think of where you'd want to do this intentionally, perhaps it should even be a run-halting error?

upgrades:  
  - upgrade_name: Upgrade Roof Insulation
    options:
      - option: env_roof_insul_r_val|roof_insul_code
  - upgrade_name: Upgrade Roof Insulation
    options:
      - option: env_roof_insul_r_val|roof_insul_efficient
  - upgrade_name: Upgrade Wall Insulation
asparke2 commented 3 years ago

@mpraprost @rHorsey FYI. Not sure if you had a reason for doing this in the full ComStock run or not.

nmerket commented 1 year ago

We might already be doing this. Someone should look at our verification code and see.