NREL / buildstockbatch

Other
22 stars 14 forks source link

Kestrel #405

Closed nmerket closed 1 year ago

nmerket commented 1 year ago

Fixes #313

A start at getting it to work on Kestrel.

Checklist

Not all may apply

github-actions[bot] commented 1 year ago

File Coverage
All files 86% :white_check_mark:
base.py 90% :white_check_mark:
exc.py 57% :white_check_mark:
hpc.py 78% :white_check_mark:
local.py 70% :white_check_mark:
postprocessing.py 84% :white_check_mark:
utils.py 91% :white_check_mark:
cloud/docker_base.py 93% :white_check_mark:
sampler/base.py 79% :white_check_mark:
sampler/downselect.py 33% :white_check_mark:
sampler/precomputed.py 93% :white_check_mark:
sampler/residential_quota.py 61% :white_check_mark:
test/shared_testing_stuff.py 85% :white_check_mark:
test/test_docker.py 33% :white_check_mark:
test/test_validation.py 97% :white_check_mark:
workflow_generator/base.py 90% :white_check_mark:
workflow_generator/commercial.py 53% :white_check_mark:
workflow_generator/residential_hpxml.py 86% :white_check_mark:

Minimum allowed coverage is 33%

Generated by :monkey: cobertura-action against 34613167b50d3f24239a4dca3d0f0dd8dd750c03

nmerket commented 1 year ago

It just occurred to me that a venv created by one user might not be able to be used by another user (which was possible with conda). We should check that and ensure it works, and if not, switch back to conda.

afontani commented 1 year ago

This would be a nice to have feature: Issue 171

nmerket commented 1 year ago

This would be a nice to have feature: Issue 171

@afontani Let's add that once we have a better handle on what the appropriate limits are on Kestrel.