Closed nweires closed 11 months ago
File | Coverage | |
---|---|---|
All files | 86% |
:white_check_mark: |
base.py | 90% |
:white_check_mark: |
exc.py | 57% |
:white_check_mark: |
hpc.py | 78% |
:white_check_mark: |
local.py | 70% |
:white_check_mark: |
postprocessing.py | 84% |
:white_check_mark: |
utils.py | 91% |
:white_check_mark: |
cloud/docker_base.py | 92% |
:white_check_mark: |
sampler/base.py | 79% |
:white_check_mark: |
sampler/downselect.py | 33% |
:white_check_mark: |
sampler/precomputed.py | 93% |
:white_check_mark: |
sampler/residential_quota.py | 61% |
:white_check_mark: |
test/shared_testing_stuff.py | 85% |
:white_check_mark: |
test/test_docker.py | 33% |
:white_check_mark: |
test/test_validation.py | 97% |
:white_check_mark: |
workflow_generator/base.py | 90% |
:white_check_mark: |
workflow_generator/commercial.py | 53% |
:white_check_mark: |
workflow_generator/residential_hpxml.py | 86% |
:white_check_mark: |
Minimum allowed coverage is 33%
Generated by :monkey: cobertura-action against d826e518d466722b170abded6a00e3e08bfcfe44
Seems good to me too. Like I said in the other PR, I'd prefer having something in the changelog to track these changes.
Sure - just added an update to changelog_dev.rst.
Pull Request Description
Moves two more sections of code into the parent class to be shared by the AWS and GCP implementations, and adds tests for them. Both are part of the tasks on the cloud that run the building simulations.
get_epws_to_download
determines which weather files are needed by a particular batch of simulations.run_simulations
runs Openstudio, writes the results to the output bucket, and cleans up any intermediate files.This is purely refactoring and does not change any behavior.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle