NREL / buildstockbatch

Other
20 stars 13 forks source link

Fixes temp directory and bigmem issues with kestrel runs #438

Closed ChristopherCaradonna closed 2 months ago

ChristopherCaradonna commented 4 months ago

Fixes # .

Pull Request Description

This fixes Kestrel run errors related the existing files in the common temp directory on local node storage. Eagle assumes there is always local storage, and sets the TMPDIR to /tmp/scratch/$USER. Kestrel always assumes there is no local disk, and sets TMPDIR to /tmp/scratch. Existing files from other users on /tmp/scratch cause buildstock batch to fail.

This fix ensures the temporary directory is set to /tmp/scratch/$USER, avoiding file conflicts.

Checklist

Not all may apply

github-actions[bot] commented 4 months ago

File Coverage
All files 87% :white_check_mark:
base.py 92% :white_check_mark:
exc.py 57% :white_check_mark:
hpc.py 78% :white_check_mark:
local.py 70% :white_check_mark:
postprocessing.py 85% :white_check_mark:
utils.py 92% :white_check_mark:
cloud/docker_base.py 88% :white_check_mark:
sampler/base.py 79% :white_check_mark:
sampler/downselect.py 33% :white_check_mark:
sampler/precomputed.py 93% :white_check_mark:
sampler/residential_quota.py 61% :white_check_mark:
test/shared_testing_stuff.py 85% :white_check_mark:
test/test_docker.py 33% :white_check_mark:
test/test_local.py 97% :white_check_mark:
test/test_validation.py 97% :white_check_mark:
workflow_generator/base.py 90% :white_check_mark:
workflow_generator/commercial.py 53% :white_check_mark:
workflow_generator/residential_hpxml.py 86% :white_check_mark:

Minimum allowed coverage is 33%

Generated by :monkey: cobertura-action against 1748ec9229ad9682256e57b12cbb5a90f1c49e05

nmerket commented 2 months ago

Are we feeling like this is ready to merge? I'd like to get this into a release so people can benefit from these bugfixes.

asparke2 commented 2 months ago

@nmerket yeah, it's good to go, we used it for the Com EUSS runs