Closed nmerket closed 1 month ago
File | Coverage | |
---|---|---|
All files | 87% |
:white_check_mark: |
base.py | 91% |
:white_check_mark: |
exc.py | 57% |
:white_check_mark: |
hpc.py | 78% |
:white_check_mark: |
local.py | 70% |
:white_check_mark: |
postprocessing.py | 84% |
:white_check_mark: |
utils.py | 92% |
:white_check_mark: |
cloud/docker_base.py | 88% |
:white_check_mark: |
sampler/base.py | 79% |
:white_check_mark: |
sampler/downselect.py | 33% |
:white_check_mark: |
sampler/precomputed.py | 93% |
:white_check_mark: |
sampler/residential_quota.py | 61% |
:white_check_mark: |
test/shared_testing_stuff.py | 85% |
:white_check_mark: |
test/test_docker.py | 33% |
:white_check_mark: |
test/test_local.py | 97% |
:white_check_mark: |
test/test_validation.py | 97% |
:white_check_mark: |
workflow_generator/base.py | 90% |
:white_check_mark: |
workflow_generator/commercial.py | 53% |
:white_check_mark: |
workflow_generator/residential_hpxml.py | 86% |
:white_check_mark: |
Minimum allowed coverage is 33%
Generated by :monkey: cobertura-action against c896135dffa422d83567b76596be507f37c8230f
@shorowit brought up the idea of (at least for residential / OS-HPXML) dropping the os_version
and os_sha
completely, and instead using the OS-HPXML required version of OpenStudio to determine the correct installer to use.
Edit: perhaps that would require OS-HPXML to store version and sha?
@shorowit brought up the idea of (at least for residential / OS-HPXML) dropping the
os_version
andos_sha
completely, and instead using the OS-HPXML required version of OpenStudio to determine the correct installer to use.Edit: perhaps that would require OS-HPXML to store version and sha?
Yeah, we would have to have the sha in that file too.
Pull Request Description
Updates CI to use whatever version of OpenStudio is specified in
national_baseline.yml
. This should future proof this from breaking again as it did when this PR merged in ResStock.Also, I took the opportunity to require the
os_version
andos_sha
in project files moving forward. We're including them in ResStock and they were added for ComStock, so it didn't make sense to maintain a default that nobody used anymore.Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle