Fix workflow generator refactor

joseph-robertson commented 4 months ago

Pull Request Description

Checklist:

[x] @joseph-robertson add entry to hpxml schema yml
[x] @rajeee user_output_variables not populated in the osw; need to update unit tests
[x] @rajeee need to pip install from unit tests (?) -- mimic what resstock does
[x] @rajeee hescore workflow generator with os_hescore_directory -> should fix issue in [#378]

Not all may apply

[x] Code changes (must work)
[x] Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
[x] Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
[x] All other unit and integration tests passing
[ ] Update validation for project config yaml file changes
[ ] Update existing documentation
[ ] Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
[ ] Add to the changelog_dev.rst file and propose migration text in the pull request

github-actions[bot] commented 4 months ago

File	Coverage
All files	`88%`	:white_check_mark:
base.py	`91%`	:white_check_mark:
exc.py	`57%`	:white_check_mark:
hpc.py	`79%`	:white_check_mark:
local.py	`70%`	:white_check_mark:
postprocessing.py	`84%`	:white_check_mark:
utils.py	`92%`	:white_check_mark:
cloud/docker_base.py	`88%`	:white_check_mark:
sampler/base.py	`78%`	:white_check_mark:
sampler/downselect.py	`33%`	:white_check_mark:
sampler/precomputed.py	`93%`	:white_check_mark:
sampler/residential_quota.py	`61%`	:white_check_mark:
test/shared_testing_stuff.py	`85%`	:white_check_mark:
test/test_docker.py	`33%`	:white_check_mark:
test/test_local.py	`97%`	:white_check_mark:
test/test_validation.py	`97%`	:white_check_mark:
workflow_generator/base.py	`89%`	:white_check_mark:
workflow_generator/commercial/commercial.py	`52%`	:white_check_mark:
workflow_generator/residential/residential_hpxml.py	`91%`	:white_check_mark:
workflow_generator/residential/test_residential_workflow_generator.py	`99%`	:white_check_mark:

Minimum allowed coverage is 33%

Generated by :monkey: cobertura-action against 7f61271b63c06af3781e8a5ce40cf217167f779b

joseph-robertson commented 4 months ago

I'm testing this using resstock here. Tests are passing there, so I'm going to merge this.