search

NREL / celavi

Codebase for the Circular Economy Lifecycle Assessment and VIsualization (CELAVI) modeling framework.
https://nrel.github.io/celavi/
GNU General Public License v3.0
9 stars 7 forks source link

Adds initial uncertainty analysis capability by refactoring #146

Closed rjhanes closed 2 years ago

rjhanes commented 2 years ago

Need to merge carefully here

The data branch that works with this refactoring (including updated config files) is tiny-uncertaintypoc

You'll likely need to create a directory called 'results' in your data folder prior to running.

rjhanes commented 2 years ago

@akey7 and @jwalzberg Thank you for the feedback! I created a second branch for this merge, uncertaintypoc-merge, that combines the fixes in issue #141 , the transportation disaggregation in #8 , and the uncertainty refactoring. Alicia - I implemented your suggested changes in that branch. Julien - I think the error is due to the old format of the lca_db file; the number of columns changed with the addition of the FIPS and state columns. If you want to try deleting that file and re-running I think that will resolve the issue.

I'll be closing this PR shortly in favor of #152 which is undergoing final testing now.

jwalzberg commented 2 years ago

@rjhanes thanks for explaining the issue. The two runs went fine after deleting the lca_db file. It took about 20000 s for the first run and about 2000 s for the second.