search

NREL / celavi

Codebase for the Circular Economy Lifecycle Assessment and VIsualization (CELAVI) modeling framework.
https://nrel.github.io/celavi/
GNU General Public License v3.0
9 stars 7 forks source link

array uncertainty leads to "LCA inventory does not exist for cement co-processing" #160

Closed rjhanes closed 2 years ago

rjhanes commented 2 years ago

@TJTapajyoti I could use some help with this issue. I'm testing the array-uncertainty branch, commit f841e97, on the tiny-array-uncertainty data branch, commit eaef1ce, using both YAML files in the data repo. You can see the changes in array-uncertainty relative to develop in PR #159 - I updated the cost methods primarily and made minor changes to three other files. I'm now seeing a missing LCA inventory starting in 2032:

LCA inventory does not exist for 2032 cement co-processing glass fiber
LCA inventory does not exist for 2032 cement co-processing epoxy

All other LCIA calculations, shortcut and from scratch, appear to be executing correctly and the material flow results looked OK. Full set of generated files and results are here:

generated-results.zip

I dug into pylca_opt_foreground.py and discovered that when stage == 'cement co-processing', the output of line 285 is all NaN values because the flow names don't match. So one of the changes I made in the array-uncertainty branch or the tiny-array-uncertainty data branch must have caused this, but I'm not sure where to start debugging. I also know that the cement LCIA calculations are being treated differently because they're based on the input of material rather than final material demand, so that is likely related somehow.

Can you take a look and recommend a course of action? We can discuss further on Thursday too.

tjlca commented 2 years ago

Solved! Please reclone data repo tiny uncertainty array