NREL / celavi

Codebase for the Circular Economy Lifecycle Assessment and VIsualization (CELAVI) modeling framework.
https://nrel.github.io/celavi/
GNU General Public License v3.0
9 stars 7 forks source link

pyomo_postprocess method has unused parameters #164

Closed rjhanes closed 2 years ago

rjhanes commented 2 years ago

In insitu_emission.py, lines 116-118:

    def pyomo_postprocess(options=None, instance=None, results=None):
        df = pd.DataFrame.from_dict(model.s.extract_values(), orient='index', columns=[str(model.s)])
        return df

@TJTapajyoti Should the model.s variables inside pyomo_postprocess be instance.s instead, and do options and results also need to be used somewhere?

tjlca commented 2 years ago

This is obsolete now.