search

NREL / celavi

Codebase for the Circular Economy Lifecycle Assessment and VIsualization (CELAVI) modeling framework.
https://nrel.github.io/celavi/
GNU General Public License v3.0
9 stars 7 forks source link

oaat runs 5, 6 and 17 throwing error. Seems like yaml error. #178

Closed tjlca closed 2 years ago

tjlca commented 2 years ago

Traceback (most recent call last): File "main.py", line 25, in Scenario(parser=PARSER) File "/lustre/eaglefs/projects/celavi/celavi/celavi/celavi/scenario.py", line 99, in init self.setup() File "/lustre/eaglefs/projects/celavi/celavi/celavi/celavi/scenario.py", line 249, in setup self.netw = CostGraph( File "/lustre/eaglefs/projects/celavi/celavi/celavi/celavi/costgraph.py", line 143, in init self.build_supplychain_graph() File "/lustre/eaglefs/projects/celavi/celavi/celavi/celavi/costgraph.py", line 723, in build_supplychain_graph self.supply_chain.edges[edge]["cost"] = sum( TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'

rjhanes commented 2 years ago

I haven't made any changes to 5_rtm_oaat.yaml, 6_rtb_oaat.yaml or 17_fgl_oaat.yaml since the last set of runs. There's nothing obviously wrong with the structure of any of them, and 5 and 6 were previously executing correctly, so I'll need to debug for a bit to figure out what's going on.

Questions: (1) Is the same line throwing the same error for all three scenarios? (2) Has scenario 17_fgl_oaat executed correctly at all since commit 5626f59?

Update 2:06pm: I have a fix for the error with scenarios 5 and 6 - there was an orphan return statement in the rotor teardown cost method that caused it to return None when array uncertainty was used on the rotor teardown parameters. Luckily this wouldn't have affected any of the other OAAT scenarios nor the stochastic scenario - meaning that whatever is wrong with scenario 17, it won't be addressed with this fix. I'll test the fix & commit it, then move on to investigating the error with scenario 17.

rjhanes commented 2 years ago

I'm unable to reproduce any kind of error running scenario 17_fgl_oaat.yaml (adapted for tiny-data: no location filtering, using fake capacity expansion dataset) on commit acae063 and tiny data commit 465c78f. I checked the diagnostic plots and everything looks like I would expect it to.

@TJTapajyoti I'm guessing you're executing runs on the pylca2.0-upgrade branch instead of develop? That branch doesn't have the fix for issue #175 and I suspect that's the problem here. Please merge in PR #176 to develop and test again using develop. In the future please only use develop (or main, if it was recently released) to get official results.

tjlca commented 2 years ago

Resolved! Thank you. The 17 was due to the wrong branch being used.