search

NREL / conan-openstudio-ruby

3 stars 5 forks source link

Fix #10 - Change CI settings to rely on Conan package tools add_common_builds #11

Closed jmarrec closed 5 years ago

jmarrec commented 5 years ago

Fix #10 - Change CI settings to rely on Conan-package-tools' add_common_builds. Cf notes in build.py.

MSVC 2017 is our windows target compiler, so for this one produce Release + Debug. Same idea for GCC 7.

The idea is that we'll produce these builds:

Platform Compiler Release Debug Verified?
Windows MSVC 2017 X X Yes
Windows MSVC 2019 X Yes
Linux GCC 7 X X Yes
Linux GCC 8 X Yes
Linux GCC 9 X Yes
Mac Xcode 10.1 X X Yes

All builds are done only for x86_64, not x86

I'm going to let CI build this PR and will check that the common builds are what I expect

jmarrec commented 5 years ago

@tijcolem I'm no longer using the ARCH env variable (in the Travis/Appveyor settings) so you can remove this one. Instead I'm passing CONAN_ARCHS from the sepcific travis / appveyor yml.

jmarrec commented 5 years ago

Hum Windows is doing 4 builds on MSVC 17 instead of 2.

+--------+--------------+--------------------+--------------------+---------------+
| arch   | build_type   | compiler.runtime   |   compiler.version | compiler      |
|--------+--------------+--------------------+--------------------+---------------|
| x86_64 | Release      | MT                 |                 15 | Visual Studio |
| x86_64 | Release      | MD                 |                 15 | Visual Studio |
| x86_64 | Debug        | MTd                |                 15 | Visual Studio |
| x86_64 | Debug        | MDd                |                 15 | Visual Studio |
+--------+--------------+--------------------+--------------------+---------------+

cf : https://ci.appveyor.com/project/ci-commercialbuildings/conan-openstudio-ruby/builds/26372207/job/sww4fjd2srgfriyd#L204

For now I'm specifying CONAN_VISUAL_RUNTIMES=MD,MDd (and I opened https://github.com/conan-io/conan-package-tools/issues/398 )

jmarrec commented 5 years ago

Ok I verified that the builds I'm getting are the one I'm expected (see table in Original Post above). CI Suceeded on all platforms. Merging