If we build FFI, package it.

lefticus commented 4 years ago

Goal: make Conan packages complete
Problem:
- currently this builds FFI on Windows because conan FFI doesn't work with Ruby
- OpenStudio has to provide its own FFI which might not have the same build settings
- this overly complicates the build story for OpenStudio
Solution: If we need to build our own FFI, package the .lib file and set it up with the conan dependencies

This simplifies the OpenStudio build story, while keeping all the builds consistent.

jmarrec commented 4 years ago

Merge into jmarrec/develop so that I can get my own CI (travis/appveyor) to build and push a test package to bintray. https://ci.appveyor.com/project/jmarrec/conan-openstudio-ruby https://travis-ci.org/jmarrec/conan-openstudio-ruby/builds/597518311

Will update the companion PR https://github.com/NREL/OpenStudio/pull/3727 to temporarily use openstudio_ruby/2.5.5@jmarrec/testing after so I can test openstudio build.

jmarrec commented 4 years ago

@lefticus Perhaps worth addressing? It pops up several times in the build log.

https://ci.appveyor.com/project/jmarrec/conan-openstudio-ruby/build/job/07edc7u6co076raj?fullLog=true#L2407

libffi.lib(closures.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance

 compiling enc/encinit.c
  encinit.c
  compiling x64-vcruntime140-ruby250.rc
  ext/extinit.obj ext/bigdecimal/bigdecimal.lib ext/cgi/escape/escape.lib ext/continuation/continuation.lib ext/coverage/coverage.lib ext/date/date_core.lib ext/digest/digest.lib ext/digest/bubblebabble/bubblebabble.lib ext/digest/md5/md5.lib ext/digest/rmd160/rmd160.lib ext/digest/sha1/sha1.lib ext/digest/sha2/sha2.lib ext/etc/etc.lib ext/fcntl/fcntl.lib ext/fiber/fiber.lib ext/fiddle/fiddle.lib ext/io/console/console.lib ext/io/nonblock/nonblock.lib ext/io/wait/wait.lib ext/json/generator/generator.lib ext/json/parser/parser.lib ext/nkf/nkf.lib ext/objspace/objspace.lib ext/openssl/openssl.lib ext/pathname/pathname.lib ext/psych/psych.lib ext/racc/cparse/cparse.lib ext/rbconfig/sizeof/sizeof.lib ext/ripper/ripper.lib ext/sdbm/sdbm.lib ext/socket/socket.lib ext/stringio/stringio.lib ext/strscan/strscan.lib ext/win32/resolv/resolv.lib ext/zlib/zlib.lib enc/encinit.obj enc/libenc.lib enc/libtrans.lib
  linking shared-library x64-vcruntime140-ruby250.dll
 libffi.lib(closures.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
     Creating library dummy.lib and object dummy.exp
  Generating code
  Finished generating code

lefticus commented 4 years ago

@jmarrec I'll look and see if I can do anything about the different link options. Regarding pushing to bintray - I thought the appveyor file did that already?

jmarrec commented 4 years ago

@lefticus master will push the stable channel on bintray. develop will push the testing channe on bintray. All other won't publish a bintray package.

cf my changes in build.py

jmarrec commented 4 years ago

I'm going to merge this to develop so we push a openstudio/2.5.5@nrel/testing package.

NREL / conan-openstudio-ruby

If we build FFI, package it. #18