Open jmarrec opened 5 years ago
For the item above, I looked around and could not find options to build readline statically for osx. Using the conan dylib readline libs is causing issues as openstudio cli has references to the libhistory.dylib and libreadline.dylib at runtime, so running the cli on another machine that does not have these, it crashes.
e.g.
$ openstudio openstudio_version
dyld: Library not loaded: /Users/jenkins/.conan/data/readline/7.0/bincrafters/stable/package/988863d075519fe477ab5c0452ee71c84a94de8a/lib/libhistory.7.dylib
If we can't build static readline, then I think we need to ship these dylibs with the cli. Conan has a guide on how to modify rpath and import the dylibs. I think this would work but maybe use this as last resort if we can't get static conan readline to work? Or we could use the brew version of readline that does have static.
For now I think we should fall back to using the brew readline version that has static lib.
I've been wanting to try out the SWIG 4 release. I think we can try that out now once we have a good baseline of develop3 to compare against. I'm not sure that anyone has tried the C# bindings in develop3 yet.
For conan-readline on mac as static, I tweaked the conan-readline recipe, and I have not seen any side effects of building static readline yet. cf https://github.com/bincrafters/conan-readline/pull/8
I then proceeded to get conan-openstudio-ruby to use my fork of readline static, and that builds and links correctly as well, and test_package works as before, https://github.com/NREL/conan-openstudio-ruby/pull/17
I will test a full OpenstudioApplication build now to check if that solves our homebrew dependency.
So to recap: conan-readline > NREL/conan-openstudio-ruby:test_static_readline_mac > NREL/OpenStudio:test_static_readline_mac > NREL/OpenStudioApplication:test_static_readline_mac
Following #7 Next steps:
with_libyaml=True
fails to link on Windows