NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Consistency in upgrade cost parameters #122

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

Here are some entries in total_upgrade_costs.json:

        "type": "New Capacitor controller",
        "count": 0,
        "total_cost_usd": 0.0
    },
    {
        "type": "New substation LTC",
        "count": 1,
        "total_cost_usd": 15000.0
    },
    {
        "type": "Substation transformer",
        "count": 1,
        "total_cost_usd": 37200.0
    },
    {
        "type": "Transformer",
        "count": 4,
        "total_cost_usd": 28800.0
    }
  1. Is there a reason why do the first two include New in their names and the second two do not? Isn't New implied?
  2. Should these parameters be defined in an Enum rather than free-form text in order to restrict values and help with consistency?