search

NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Transform upgrades file has `bus` and `buses` #125

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

The file transformer_upgrades.json reports an array of transformer objects. Each of those objects has a bus field as well as a buses field. What is the difference? Does bus need to be there?

Is this also tied to the fields kV, kVs, kVA, kVAs, conn, conns?

daniel-thom commented 2 years ago

One possible solution is to separate disco parameters from OpenDSS parameters. There can be a sub-object called opendss_parameters.

ann-sherin commented 2 years ago

->A lot of these fields are opendss names. So, I think it should be fine to let it stay. Can add documentation on the additional fields added.

->Also, would prefer not changing the structure since this json is converted in a table, while computing costs. And the parameters are accessed from the table.