NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Transformer file output formatting #126

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

The transformer_upgrades.json file

  1. Defines the conn field like this:

    "conn": "wye ",

    Does the value need to have the trailing space removed?

  2. Does this value need to be changed to an array of floats?

    "Xscarray": "[2.4, 1.6, 2.4]",
  3. Is this the correct type?

    "taps": "['1', '1', '1']",

If this file is just a dump of an opendssdirect dataframe and no one is ever supposed to look at it, maybe none of this matters.

daniel-thom commented 2 years ago

Same as #125

ann-sherin commented 2 years ago

Changed to be of sensible datatypes