search

NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Hosting capacity plots aren't created for snapshot simulations #135

Open daniel-thom opened 2 years ago

daniel-thom commented 2 years ago

Here are the post-processing jobs for snapshot hosting capacity:

+-------+------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------+
| index | name |                                                                                             command                                                                                             | blocked_by (job names) |
+-------+------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------+
|   0   |  1   |                                                                disco make-summary-tables $JADE_PIPELINE_OUTPUT_DIR/output-stage1                                                                |                        |
|   1   |  2   |                              disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=control_mode --time-point=max_pv_load_ratio                             |           1            |
|   2   |  3   |                                  disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=control_mode --time-point=max_load                                  |           2            |
|   3   |  4   |                              disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=control_mode --time-point=daytime_min_load                              |           3            |
|   4   |  5   |                                disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=control_mode --time-point=pv_minus_load                               |           4            |
|   5   |  6   |                                  disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=pf1 --time-point=max_pv_load_ratio                                  |           5            |
|   6   |  7   |                                       disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=pf1 --time-point=max_load                                      |           6            |
|   7   |  8   |                                   disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=pf1 --time-point=daytime_min_load                                  |           7            |
|   8   |  9   |                                    disco-internal compute-hosting-capacity $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario=pf1 --time-point=pv_minus_load                                    |           8            |
|   9   |  10  |                                                       disco-internal plot $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario control_mode                                                       |           9            |
|   10  |  11  |                                                            disco-internal plot $JADE_PIPELINE_OUTPUT_DIR/output-stage1 --scenario pf1                                                           |           10           |
|   11  |  12  | disco ingest-tables --task-name "snapshot-test" --database $JADE_PIPELINE_OUTPUT_DIR/output-stage1/results.sqlite --model-inputs snapshot-feeder-models $JADE_PIPELINE_OUTPUT_DIR/output-stage1 |           11           |
+-------+------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------+

The post-processing scripts for compute-hosting-capacity accept the parameters scenario and time-point. The plot script does not accept time-point and so cannot correctly identify the summary JSON files. You get an error like this:

ERROR [disco.postprocess.plots plots.py:87] : Overall hosting capacity JSON file does not exist, please check your scenario.