NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Hc postprocess #28

Closed jgu2 closed 3 years ago

jgu2 commented 3 years ago

This PR include two features,

  1. Hosting Capacity Postprocess

    disco-internal compute-hosting-capacity <OUTPUT_DIR>

    Integrated into pipeline.

    disco create-pipeline template tests/data/smart-ds/substations --hosting-capacity
  2. Metrics query tool with Jupyter notebook

    jupyter notebook disco/postprocess/toolbox/query_tool.ipynb
jgu2 commented 3 years ago

I made the notebook UI to be more compact. After open the notebook, need to execute %run -i "query_tool.py" to get the UI. let's take current version as a start, I think it could have more spaces to improve, like to support multiple conditions on same field.

daniel-thom commented 3 years ago

I made the notebook UI to be more compact. After open the notebook, need to execute %run -i "query_tool.py" to get the UI. let's take current version as a start, I think it could have more spaces to improve, like to support multiple conditions on same field.

I tested this out. The simulations ran perfectly. However, when I ran the notebook it wasn't obvious. I had to struggle to find that I needed to load output/output-stage2. Then the default behavior also wasn't clear. Do I need to select everything that I want to see? Can the default be to show everything? It's OK if everything isn't perfect right away. Maybe I need another demo.

jgu2 commented 3 years ago

The default behavior was not set yet, it's plain inputs. It should be the places we need to improve as well.