search

NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Test that PV controllers are correctly added #53

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

This snapshot test would have caught this week's bug. I tried to add comparison tests of thermal and voltage metrics for the max_pv_load_ratio snapshot scenario, but the results are always the same (with our test data). If anyone has an idea about how to ensure that there are differences, let me know.

KwamiS commented 2 years ago

This test will always fail for some cases because these metrics do not have to be different for PF1 and Voltvar. What can be done, if anything, is comparing maximum voltage across PV buses for PF1 against Voltvar. Even that would only work if there is a reason for the voltvar control to kick in. When Voltvar control is enabled, it's only when there is a need for it to inject or consume reactive power that it will do so.

daniel-thom commented 2 years ago

This test will always fail for some cases because these metrics do not have to be different for PF1 and Voltvar. What can be done, if anything, is comparing maximum voltage across PV buses for PF1 against Voltvar. Even that would only work if there is a reason for the voltvar control to kick in. When Voltvar control is enabled, it's only when there is a need for it to inject or consume reactive power that it will do so.

Then we should change the input data in at least one case to guarantee that the volt-var control has an effect.