search

NREL / ditto

DiTTo is a Distribution Transformation Tool that aims at providing an open source framework to convert various distribution systems modeling formats.
https://nrel.github.io/ditto/
BSD 3-Clause "New" or "Revised" License
70 stars 36 forks source link

Bugs in Transformers KVA values #160

Open NicolasGensollen opened 6 years ago

NicolasGensollen commented 6 years ago

There seems to be inconsistencies between readers, writers, and metric computation module about the transformers KVA values. Since this is a Winding attribute, some parsers divide the transformer's KVA by the number of windings and some don't. Likewise some writers sum across windings while some don't... This is confusing and currently creating a lot of bugs.

For example, the bug fix #144 solved some bugs when computing metrics from OpenDSS but introduced bugs when doing OpenDSS --> CYME conversion such that we are planning to revert it...

I think we should move back (I'm afraid I'm the one who suggested the initial move...) this attribute from the Winding to the PowerTransformer itself to avoid confusion, even if this means spending some time updating the code.

Does someone have an opinion on this? @tarekelgindy ?

NicolasGensollen commented 6 years ago

Might also be the opportunity to take care of #49...