search

NREL / ditto

DiTTo is a Distribution Transformation Tool that aims at providing an open source framework to convert various distribution systems modeling formats.
https://nrel.github.io/ditto/
BSD 3-Clause "New" or "Revised" License
69 stars 36 forks source link

Cyme bugfixes #268

Closed tarekelgindy closed 5 years ago

tarekelgindy commented 5 years ago

Small bugfixes to Cyme reader and opendss writer. Also automatically calculating the nominal voltages when reading from cyme. As these aren't explicitly represented in CYME they were left as None, but doing this post-processing step as part of the reader makes more sense.

codecov-io commented 5 years ago

Codecov Report

Merging #268 into master will increase coverage by 0.03%. The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   41.61%   41.64%   +0.03%     
==========================================
  Files          83       83              
  Lines       18010    18030      +20     
==========================================
+ Hits         7494     7509      +15     
- Misses      10516    10521       +5
Impacted Files Coverage Δ
ditto/writers/opendss/write.py 62.38% <0%> (-0.13%) :arrow_down:
ditto/readers/cyme/read.py 61.38% <83.33%> (+0.03%) :arrow_up:
ditto/modify/system_structure.py 17.62% <0%> (+0.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62722cd...d701862. Read the comment docs.