NREL / ditto

DiTTo is a Distribution Transformation Tool that aims at providing an open source framework to convert various distribution systems modeling formats.
https://nrel.github.io/ditto/
BSD 3-Clause "New" or "Revised" License
69 stars 36 forks source link

Timeseries development #270

Closed tarekelgindy closed 5 years ago

tarekelgindy commented 5 years ago

Merging in many changes made over the last few months into master

codecov-io commented 5 years ago

Codecov Report

Merging #270 into master will decrease coverage by 0.67%. The diff coverage is 32.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   41.64%   40.97%   -0.68%     
==========================================
  Files          83       83              
  Lines       18030    19145    +1115     
==========================================
+ Hits         7509     7844     +335     
- Misses      10521    11301     +780
Impacted Files Coverage Δ
ditto/readers/abstract_reader.py 34.25% <1.26%> (-21.85%) :arrow_down:
ditto/models/storage.py 100% <100%> (ø) :arrow_up:
ditto/models/powertransformer.py 100% <100%> (ø) :arrow_up:
ditto/readers/opendss/read.py 60.58% <100%> (ø) :arrow_up:
ditto/models/node.py 100% <100%> (ø) :arrow_up:
ditto/models/line.py 100% <100%> (ø) :arrow_up:
ditto/modify/system_structure.py 24.71% <100%> (+7.09%) :arrow_up:
ditto/models/timeseries.py 93.75% <100%> (+0.89%) :arrow_up:
ditto/metrics/network_analysis.py 48.99% <11.11%> (+0.34%) :arrow_up:
ditto/writers/opendss/write.py 55.14% <32.37%> (-7.24%) :arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62f04b9...41153d0. Read the comment docs.

kdheepak commented 5 years ago

There's a typo in Line 127: https://github.com/NREL/ditto/pull/270/files#diff-86bd7fbb029b0906351f182873821b3dR127

kdheepak commented 5 years ago

Why is __dict__ being used here?

https://github.com/NREL/ditto/blob/7631e1a5bb7dc6e7e0592060a2dff8091f0e7710/ditto/metrics/network_analysis.py#L778