search

NREL / ditto

DiTTo is a Distribution Transformation Tool that aims at providing an open source framework to convert various distribution systems modeling formats.
https://nrel.github.io/ditto/
BSD 3-Clause "New" or "Revised" License
68 stars 36 forks source link

Installing mdbtools in DiTTo #307

Closed kavuribhavya closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #307 into master will increase coverage by 0.02%. The diff coverage is 44.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #307      +/-   ##
=========================================
+ Coverage   40.38%   40.4%   +0.02%     
=========================================
  Files          86      88       +2     
  Lines       20074   20157      +83     
=========================================
+ Hits         8106    8144      +38     
- Misses      11968   12013      +45
Impacted Files Coverage Δ
ditto/readers/synergi/__init__.py 100% <100%> (ø) :arrow_up:
ditto/readers/synergi/db_parser.py 26.92% <100%> (ø) :arrow_up:
ditto/readers/synergi/pandas_access.py 29.68% <29.68%> (ø)
ditto/readers/synergi/utils.py 88.23% <88.23%> (ø)
ditto/metrics/network_analysis.py 48.99% <0%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3c242c...ad444d8. Read the comment docs.

kdheepak commented 5 years ago

I don't like storing non-text files in git repos. The only free alternative (I think) is to store it on gists or releases. Storing it in a DiTTo release makes sense too. You'll have to make a release, upload the files there and then reference the release. You could also create a named release called "downloads". But creating a release still corrupts the release time line, which is why I thought this was the best compromise. Also, anyone that is interested in mdb-tools binaries can download it too.

Ideally, we would use conda and conda install ditto would install everything a user needed, and we wouldn't need to do any of these hacks. But even that requires creating conda packages for mdb-tools. This is essentially what I did right now, but it's slightly more work doing that with conda and hosting everything, and then making a ditto conda package. If there's enought interest I will go ahead and do that.

kavuribhavya commented 5 years ago

@kdheepak, For now, we will use the tar files stored in your "download" release. I will go ahead and merge the current changes.