search

NREL / ditto

DiTTo is a Distribution Transformation Tool that aims at providing an open source framework to convert various distribution systems modeling formats.
https://nrel.github.io/ditto/
BSD 3-Clause "New" or "Revised" License
69 stars 36 forks source link

Probably shouldn't import private methods from other packages #426

Closed vtnate closed 10 months ago

vtnate commented 11 months ago

Traitlets removed traitlets.traitlets._deprecated_method in v5.10 with this line in https://github.com/ipython/traitlets/pull/838

Several potential solutions that could work:

  1. pin your traitlets dependency to <5.10
  2. change the statement where you import _deprecated_method to traitlets.utils.warnings.deprecated_method
  3. _deprecated_method doesn't appear to be used in this package. Can this import simply be deleted?
  4. Revert https://github.com/NREL/ditto/commit/3b40156723d38c7a2bec7cdab71dbfaf2214fdad to avoid this situation