search

NREL / edv_synthetic_smart_meter_data

Other
1 stars 1 forks source link

Bdgp2 bugfix #132

Closed lainsworth8801 closed 3 years ago

lainsworth8801 commented 4 years ago
  1. change BSync standard to 2.0;
  2. Added bdgp2 hourly data to BuildingSync file;
  3. Added annual total kwh and btu values;
  4. Added annual peak value;
  5. Calculate_metrics cleanup;
  6. First pass on export_synthetic_data: rescue empty csvs;
  7. merged BDGP2_implementation.

Total value spot check: Screen Shot 2020-09-05 at 10 37 41 AM

Screen Shot 2020-09-05 at 10 37 49 AM

Peak value spot check: Screen Shot 2020-09-08 at 3 20 07 PM

lainsworth8801 commented 4 years ago

@lainsworth8801 please add tests for the updated workflow. There isn't currently any single file documented that proves the summation / aggregation algorithms work as expected. This was a problem beforehand (and why we initially needed this update), as we were unable to verify correctness. I would prove out the calcs for 1-2 files for electricity (and natural gas?)

This is definitely in the scope thanks!

lainsworth8801 commented 3 years ago

@corymosiman12 @JanghyunJK Opened #135 to track testing progress.

JanghyunJK commented 3 years ago

@lainsworth8801 I don't think we can ask Cory for reviews unless if it is related to the BSync gem. We can talk if we need another reviewer outside of EDV.