search

NREL / edv_synthetic_smart_meter_data

Other
1 stars 1 forks source link

[Task: quality check] require 'openstudio/extension' in BuildingSync-gem/lib/buildingsync/extension.rb #49

Closed corymosiman12 closed 4 years ago

corymosiman12 commented 5 years ago

This is a general ticket to figure out best practices for setting the following variables (as you can see were changed in this most recent commit https://github.com/NREL/edv-experiment-1/commit/939afdeea2f3d8cf1d8f0924315e904dffe48b78): image

Nick and I had to modify the BuildingSync-gem/lib/buildingsync/extension.rb file to require the 'openstudio/extension', else, things would fail when trying to run.

Nick can explain / elaborate a lot better, but I'm opening this up as a general discussion / reminder for us.

@nllong or @TMaile can you add me as a contributor to the BuildingSync-gem repo?

In the meantime, @TMaile will you add: image

to the branch being requested by the edv-experiment-1 Gemfile (looks like DA_Level1_BldgSync2.0)

Thank you!

TMaile commented 5 years ago

I just added the 'openstudio/extension' to the BuildignSync-gem.

corymosiman12 commented 5 years ago

@TMaile I see in the Gemfile you changed the branch to 'Develop' - in the EDV gemfile, there are some pointing to 'develop', some to 'DA', and some to 'master'. Do we have a standard approach for which branches we should be testing / pointing to? Just trying to make sure I understand for running tests / etc.

TMaile commented 5 years ago

@corymosiman12 As I understand it, master is the main branch, in develop we are mainly developing new features, and DA are branches we (Digital Alchemy) created. When we merge code back into develop then we also update the pointers.

corymosiman12 commented 5 years ago

Got it - thanks.